Page MenuHomePhabricator
Differential D10812

Phriction - move "move" business logic to the editor
ClosedPublic
Actions

Authored by btrahan on Nov 7 2014, 7:14 PM.
Tags
None
Referenced Files
F14352393: D10812.diff
Thu, Dec 19, 1:40 PM
Unknown Object (File)
Sun, Dec 8, 7:42 PM
Unknown Object (File)
Thu, Dec 5, 3:44 PM
Unknown Object (File)
Tue, Dec 3, 8:42 PM
Unknown Object (File)
Sat, Nov 30, 5:45 PM
Unknown Object (File)
Fri, Nov 29, 2:51 PM
Unknown Object (File)
Wed, Nov 27, 4:15 AM
Unknown Object (File)
Mon, Nov 25, 9:24 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T4029: Support policies on Phriction wiki articles
Commits
Restricted Diffusion Commit
rPb538611e2928: Phriction - move "move" business logic to the editor
Summary

Ref T4029. Even more code consolidation and cleanup for the long term benefits!

Test Plan

moved a page successfully. tried to move a page to an existing page and got an error. did the two tab trick to try to move a deleted page and got an error.

Diff Detail

Repository
rP Phabricator
Branch
T4029
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2985
Build 2989: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25944.Nov 7 2014, 7:14 PM
btrahan added a task: T4029: Support policies on Phriction wiki articles.
btrahan retitled this revision from to Phriction - move "move" business logic to the editor.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptNov 7 2014, 7:14 PM
Harbormaster completed remote builds in B2985: Diff 25944.Nov 7 2014, 7:15 PM
btrahan mentioned this in D10813: Phriction - add "create" conduit endpoint.Nov 7 2014, 7:40 PM
epriestley accepted this revision.Nov 7 2014, 7:42 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 7 2014, 7:42 PM
Closed by commit rPb538611e2928: Phriction - move "move" business logic to the editor (authored by btrahan, committed by btrahan). · Explain WhyNov 7 2014, 7:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
phriction/
controller/
84 lines
editor/
48 lines

Diff 25944

View Options

src/applications/phriction/controller/PhrictionMoveController.php

Loading...
View Options

src/applications/phriction/editor/PhrictionTransactionEditor.php

Loading...
Phabricator · Built by Phacility