Differential D10795
Phriction - consolidate edit business logic into Editor Authored by btrahan on Nov 6 2014, 8:21 PM. Tags None Referenced Files
Subscribers
Details
Ref T4029. Some business logic lives outside the editor. This revision moves that logic from the edit controller into the editor proper. This makes re-using that business logic across other endpoints - say like a conduit end point - possible. This is also part of the general modernization quest for phriction I am on. This diff also restores the functionality where you can delete a document by wiping out the content and saving. tried to make a document with no title or content and saw errors. opened a document for edit with user 1, then made edits with user 2, then saw an error when i made the edit with user 1. clicking "overwrite changes" then worked. deleted a document by wiping out the body and clicking save.
Diff Detail
Event TimelineComment Actions Oh, my inline misunderstood the behavior. The API seems a little confusing to me but not unreasonable. Maybe clarify it a bit.
Comment Actions Specifically, when I was reading through, it would have been clearest if there were separate flags for the caller intent (like $ignoreEditConflicts) and generation of the conflict warning (like $rasiedVersionError). Comment Actions use a slighter better name - get/set ProcessContentVersionError - and then update negation as necessary. re-run tests - they still pass | ||||||||||||||||||||||||||||||||||||||||||||||||