Page MenuHomePhabricator

Assume utf8mb4 support
ClosedPublic

Authored by epriestley on Nov 6 2014, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 10:25 PM
Unknown Object (File)
Sun, Dec 29, 10:32 PM
Unknown Object (File)
Mon, Dec 23, 10:14 AM
Unknown Object (File)
Thu, Dec 19, 1:40 PM
Unknown Object (File)
Thu, Dec 19, 1:40 PM
Unknown Object (File)
Dec 4 2024, 8:57 PM
Unknown Object (File)
Nov 30 2024, 7:28 PM
Unknown Object (File)
Nov 28 2024, 11:05 PM
Subscribers

Details

Summary

Ref T1191. This stops throwing an exception for non-BMP data when constructing queries.

  • For installs which have already adjusted, this allows emoji and other 4-byte characters to work.
  • For installs which have not adjusted yet but do have STRICT_ALL_TABLES set, MySQL will raise an error intead ("Incorrect string value...").
  • For installs which have not adjusted and also do not use STRICT_ALL_TABLES, this will silently truncate data. This is potentially a security risk. However, these installs are warned about the risk of leaving STRICT_ALL_TABLES disabled, there's no known way to exploit this issue, and they'll be auto-adjusted soon.
Test Plan

Ran locally and on secure.phabricator.com with this patch for a long time.

Diff Detail

Repository
rPHU libphutil
Branch
store2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2969
Build 2973: [Placeholder Plan] Wait for 30 Seconds