Page MenuHomePhabricator

Add HiDPI favicons
ClosedPublic

Authored by chad on Nov 6 2014, 8:54 PM.
Tags
None
Referenced Files
F14721527: D10796.diff
Fri, Jan 17, 10:50 PM
Unknown Object (File)
Thu, Dec 19, 4:21 PM
Unknown Object (File)
Thu, Dec 19, 4:21 PM
Unknown Object (File)
Thu, Dec 19, 4:21 PM
Unknown Object (File)
Dec 12 2024, 1:48 AM
Unknown Object (File)
Dec 8 2024, 5:39 AM
Unknown Object (File)
Dec 6 2024, 5:50 AM
Unknown Object (File)
Dec 3 2024, 8:53 PM
Subscribers

Details

Summary

Fixes T5939. Specifically, 16, 32, and 64 bit pngs are in the .ico file. Apple icons are added to support non-Retina and Retina iPad and iPhone. Follows roughly Apple guidelines here: https://developer.apple.com/library/ios/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

Test Plan

Tested Chrome, Firefox on Mac. Much cleaner on Retina.

pasted_file (40×91 px, 6 KB)

Diff Detail

Repository
rP Phabricator
Branch
favicon
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2967
Build 2971: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Add HiDPI favicons.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad edited the test plan for this revision. (Show Details)
epriestley edited edge metadata.
This revision is now accepted and ready to land.Nov 8 2014, 1:03 AM
This revision was automatically updated to reflect the committed changes.