Fixes T5939. Specifically, 16, 32, and 64 bit pngs are in the .ico file. Apple icons are added to support non-Retina and Retina iPad and iPhone. Follows roughly Apple guidelines here: https://developer.apple.com/library/ios/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T5939: Phabricator favicon is not HiDPI compatable
- Commits
- Restricted Diffusion Commit
rP97f05d6ab892: Add HiDPI favicons
Tested Chrome, Firefox on Mac. Much cleaner on Retina.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- favicon
- Lint
Lint Warnings Severity Location Code Message Warning src/view/page/PhabricatorBarePageView.php:82 TXT3 Line Too Long Warning src/view/page/PhabricatorBarePageView.php:90 TXT3 Line Too Long Warning src/view/page/PhabricatorBarePageView.php:98 TXT3 Line Too Long - Unit
Tests Passed - Build Status
Buildable 2966 Build 2970: [Placeholder Plan] Wait for 30 Seconds