Differential D10793

Conpherence - fix fatal on list view for 100+ messages
ClosedPublic
Actions

Authored by btrahan on Nov 6 2014, 1:03 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T6480: Conpherence list view fatals

Commits

Restricted Diffusion Commit
rP351f4722d960: Conpherence - fix fatal on list view for 100+ messages

Summary

Fixes T6480. @epriestley is very popular and has over 100 messages, thus triggering this issue. fix the typo because bugs are bad.

Test Plan

set limit to 1, observed fatal, applied patch and fatal went away

Diff Detail

Repository

rP Phabricator

Branch

T6480

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2958
Build 2962: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25902.Nov 6 2014, 1:03 AM

btrahan added a task: T6480: Conpherence list view fatals.

btrahan retitled this revision from to Conpherence - fix fatal on list view for 100+ messages.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a subscriber: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptNov 6 2014, 1:03 AM

Harbormaster completed remote builds in B2958: Diff 25902.Nov 6 2014, 1:04 AM

everyone loves me :3

This revision is now accepted and ready to land.Nov 6 2014, 1:30 AM

Closed by commit rP351f4722d960: Conpherence - fix fatal on list view for 100+ messages (authored by btrahan, committed by btrahan). · Explain WhyNov 6 2014, 1:32 AM

This revision was automatically updated to reflect the committed changes.

chad awarded a token.Nov 6 2014, 2:42 AM

Revision Contents
Changeset List

Path

Size

src/

applications/

conpherence/

controller/

ConpherenceListController.php

2 lines

Diff 25902

View Options

src/applications/conpherence/controller/ConpherenceListController.php

Conpherence - fix fatal on list view for 100+ messagesClosedPublicActions