Page MenuHomePhabricator
Differential D10768

Apply remarkup-code padding to child spans as well
ClosedPublic
Actions

Authored by chad on Oct 31 2014, 5:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 6:00 PM
Unknown Object (File)
Thu, Jan 23, 6:01 PM
Unknown Object (File)
Thu, Jan 23, 6:01 PM
Unknown Object (File)
Thu, Jan 23, 6:00 PM
Unknown Object (File)
Dec 26 2024, 1:54 AM
Unknown Object (File)
Dec 14 2024, 5:57 PM
Unknown Object (File)
Dec 5 2024, 8:46 PM
Unknown Object (File)
Nov 21 2024, 10:01 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6440: Green background on syntax highlighted code for char-level changes has weird padding
Commits
Restricted Diffusion Commit
rP53493ccf9396: Apple remarkup-code padding to child spans as well.
Summary

Fixes T6440. The issue is when a nested span appears, we don't apply the spacing.

Test Plan

Test a new diff in my sandbox that exhibits the issue. Ensure spacing now aligns.

Diff Detail

Repository
rP Phabricator
Branch
diff-padding
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2924
Build 2928: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25846.Oct 31 2014, 5:42 PM
chad retitled this revision from to Apple remarkup-code padding to child spans as well..
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
chad added a task: T6440: Green background on syntax highlighted code for char-level changes has weird padding.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 31 2014, 5:42 PM
Harbormaster completed remote builds in B2924: Diff 25846.Oct 31 2014, 5:43 PM
epriestley accepted this revision.Oct 31 2014, 5:44 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 31 2014, 5:44 PM
epriestley added a comment.Oct 31 2014, 5:44 PM

First time I've seen "apple" used as a verb.

Closed by commit rP53493ccf9396: Apple remarkup-code padding to child spans as well. (authored by chad, committed by chad). · Explain WhyOct 31 2014, 5:45 PM
This revision was automatically updated to reflect the committed changes.
chad added a comment.Oct 31 2014, 5:46 PM

Yeah, phat phingered.

chad retitled this revision from Apple remarkup-code padding to child spans as well. to Apply remarkup-code padding to child spans as well.Oct 31 2014, 5:47 PM
chad edited edge metadata.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
core/
5 lines

Diff 25846

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/core/syntax.css

Loading...
Phabricator · Built by Phacility