Audit - another partial fix to commit re-parsing bug
ClosedPublic
Actions

Authored by btrahan on Oct 21 2014, 12:25 AM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6350: Diffusion spamming the feed/commits going weird

Commits

Restricted Diffusion Commit
rPd248bc47cf00: Audit - another partial fix to commit re-parsing bug

Summary

Ref T6350. We build $sql based on whose subscribed. If no one is subscribed, then we have no query to run.

Test Plan

observed one error disappearing from my daemon log. Also, more doing it live.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25760.Oct 21 2014, 12:25 AM

btrahan retitled this revision from to Audit - another partial fix to commit re-parsing bug.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

btrahan added a task: T6350: Diffusion spamming the feed/commits going weird.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 21 2014, 12:25 AM

btrahan added inline comments.Oct 21 2014, 12:26 AM

src/applications/feed/PhabricatorFeedStoryPublisher.php
124–126	the block of peril apparently...

Harbormaster completed remote builds in B2869: Diff 25760.Oct 21 2014, 12:26 AM

chad accepted this revision.Oct 21 2014, 12:26 AM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 21 2014, 12:26 AM

Closed by commit rPd248bc47cf00: Audit - another partial fix to commit re-parsing bug (authored by btrahan, committed by btrahan). · Explain WhyOct 21 2014, 12:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

feed/

PhabricatorFeedStoryPublisher.php

15 lines

Diff 25761

View Options

src/applications/feed/PhabricatorFeedStoryPublisher.php

Audit - another partial fix to commit re-parsing bugClosedPublicActions