Page MenuHomePhabricator
Differential D10731

Audit - another partial fix to commit re-parsing bug
ClosedPublic
Actions

Authored by btrahan on Oct 21 2014, 12:25 AM.
Tags
None
Referenced Files
F15459011: D10731.id.diff
Mon, Mar 31, 9:06 AM
F15455005: D10731.id.diff
Sat, Mar 29, 9:49 PM
F15453313: D10731.id25761.diff
Sat, Mar 29, 10:51 AM
F15449320: D10731.id25760.diff
Fri, Mar 28, 9:31 AM
F15444569: D10731.diff
Thu, Mar 27, 10:09 AM
F15430382: D10731.id25760.diff
Mon, Mar 24, 7:24 AM
F15428797: D10731.id25760.diff
Sun, Mar 23, 10:25 PM
F15412007: D10731.diff
Wed, Mar 19, 10:49 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Maniphest Tasks
T6350: Diffusion spamming the feed/commits going weird
Commits
Restricted Diffusion Commit
rPd248bc47cf00: Audit - another partial fix to commit re-parsing bug
Summary

Ref T6350. We build $sql based on whose subscribed. If no one is subscribed, then we have no query to run.

Test Plan

observed one error disappearing from my daemon log. Also, more doing it live.

Diff Detail

Repository
rP Phabricator
Branch
importfix2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2869
Build 2873: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25760.Oct 21 2014, 12:25 AM
btrahan retitled this revision from to Audit - another partial fix to commit re-parsing bug.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
btrahan added a task: T6350: Diffusion spamming the feed/commits going weird.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 21 2014, 12:25 AM
btrahan added inline comments.Oct 21 2014, 12:26 AM
src/applications/feed/PhabricatorFeedStoryPublisher.php
124–126

the block of peril apparently...

Harbormaster completed remote builds in B2869: Diff 25760.Oct 21 2014, 12:26 AM
chad accepted this revision.Oct 21 2014, 12:26 AM
chad edited edge metadata.
This revision is now accepted and ready to land.Oct 21 2014, 12:26 AM
Closed by commit rPd248bc47cf00: Audit - another partial fix to commit re-parsing bug (authored by btrahan, committed by btrahan). · Explain WhyOct 21 2014, 12:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
feed/
15 lines

Diff 25760

View Options

src/applications/feed/PhabricatorFeedStoryPublisher.php

Loading...
Phabricator · Built by Phacility