Differential - fix bogus foreach(null)
ClosedPublic
Actions

Authored by btrahan on Oct 13 2014, 5:31 PM.

Details

Reviewers

epriestley
chad

Maniphest Tasks

T6292: Invalid argument supplied for foreach()

Commits

Restricted Diffusion Commit
rPc51489f138cb: Differential - fix bogus foreach(null)

Summary

Default $phids to array() and update it if getValue() has something pertinent... Fixes T6292.

Test Plan

just used the ole logic noodle on this one.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 25673.Oct 13 2014, 5:31 PM

btrahan added a task: T6292: Invalid argument supplied for foreach().

btrahan retitled this revision from to Differential - fix bogus foreach(null).

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 13 2014, 5:31 PM

Harbormaster completed remote builds in B2822: Diff 25673.Oct 13 2014, 5:32 PM

chad accepted this revision.Oct 13 2014, 6:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 13 2014, 6:11 PM

$this->getValue() should probably never not be an array, buuut whatevs.

Closed by commit rPc51489f138cb: Differential - fix bogus foreach(null) (authored by btrahan, committed by btrahan).Oct 13 2014, 7:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialReviewersField.php

6 lines

Diff 25685

View Options

src/applications/differential/customfield/DifferentialReviewersField.php

Differential - fix bogus foreach(null)ClosedPublicActions