Page MenuHomePhabricator

Provide a scrollbar when properties overflow on desktop
ClosedPublic

Authored by chad on Oct 12 2014, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 5:28 AM
Unknown Object (File)
Mon, Jan 27, 3:35 PM
Unknown Object (File)
Sat, Jan 25, 3:01 AM
Unknown Object (File)
Thu, Jan 23, 5:35 PM
Unknown Object (File)
Thu, Jan 23, 5:34 PM
Unknown Object (File)
Thu, Jan 23, 5:34 PM
Unknown Object (File)
Thu, Jan 23, 5:34 PM
Unknown Object (File)
Tue, Jan 21, 9:36 AM

Details

Summary

Fixes issues seen in D10690 with unit results.

Test Plan

test D10690 and locally

Diff Detail

Repository
rP Phabricator
Branch
prop-list
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2815
Build 2819: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Provide a scrollbar when properties overflow on desktop.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.

Doesn't scroll mean there's always a scrollbar? Is that definitely right? (Not auto?)

Maybe Chrome changed behaviour, but I think you're right.

chad edited edge metadata.

Use auto

If you have OSX and a laptop, and do not have a USB mouse connected, the OS doesn't really render normal scrollbars (in pretty much any app). Plugging in a mouse gives you scrollbars. Might be the issue?

"Mouse"? Is that some 90's technology?

e.g., page with a USB mouse connected:

Screen_Shot_2014-10-12_at_2.41.50_PM.png (933×1 px, 138 KB)

epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 12 2014, 9:42 PM

It's a video game controller that helps MLG pros like myself get headshots and retain their Mountain Dew sponsorships.

This revision was automatically updated to reflect the committed changes.