Page MenuHomePhabricator
Differential D10691

Provide a scrollbar when properties overflow on desktop
ClosedPublic
Actions

Authored by chad on Oct 12 2014, 9:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 12, 7:38 PM
Unknown Object (File)
Sun, Feb 9, 2:29 AM
Unknown Object (File)
Fri, Feb 7, 11:46 PM
Unknown Object (File)
Fri, Feb 7, 11:46 PM
Unknown Object (File)
Fri, Feb 7, 11:46 PM
Unknown Object (File)
Fri, Feb 7, 11:46 PM
Unknown Object (File)
Wed, Jan 29, 5:28 AM
Unknown Object (File)
Mon, Jan 27, 3:35 PM
View All Files
Subscribers
epriestley
• FelixClouse
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP3e1918d89fdc: Provide a scrollbar when properties overflow on desktop
Summary

Fixes issues seen in D10690 with unit results.

Test Plan

test D10690 and locally

Diff Detail

Repository
rP Phabricator
Branch
prop-list
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2815
Build 2819: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25662.Oct 12 2014, 9:15 PM
chad retitled this revision from to Provide a scrollbar when properties overflow on desktop.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 12 2014, 9:15 PM
Harbormaster completed remote builds in B2814: Diff 25662.Oct 12 2014, 9:16 PM
epriestley edited edge metadata.Oct 12 2014, 9:25 PM

Doesn't scroll mean there's always a scrollbar? Is that definitely right? (Not auto?)

chad added a comment.Oct 12 2014, 9:27 PM

Maybe Chrome changed behaviour, but I think you're right.

chad added a comment.Oct 12 2014, 9:33 PM

http://www.w3schools.com/cssref/playit.asp?filename=playcss_overflow-x&preval=auto

Tried Safari, Chrome, Firefox, scrollbars seem to never appear by default. Odd.

chad updated this revision to Diff 25663.Oct 12 2014, 9:36 PM
chad edited edge metadata.

Use auto

Harbormaster completed remote builds in B2815: Diff 25663.Oct 12 2014, 9:37 PM
epriestley added a comment.Oct 12 2014, 9:37 PM

If you have OSX and a laptop, and do not have a USB mouse connected, the OS doesn't really render normal scrollbars (in pretty much any app). Plugging in a mouse gives you scrollbars. Might be the issue?

chad added a comment.Oct 12 2014, 9:42 PM

"Mouse"? Is that some 90's technology?

epriestley added a comment.Oct 12 2014, 9:42 PM

e.g., page with a USB mouse connected:

Screen_Shot_2014-10-12_at_2.41.50_PM.png (933×1 px, 138 KB)

epriestley accepted this revision.Oct 12 2014, 9:42 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Oct 12 2014, 9:42 PM
epriestley added a comment.Oct 12 2014, 9:42 PM

It's a video game controller that helps MLG pros like myself get headshots and retain their Mountain Dew sponsorships.

Closed by commit rP3e1918d89fdc: Provide a scrollbar when properties overflow on desktop (authored by chad, committed by chad).Oct 12 2014, 9:43 PM
This revision was automatically updated to reflect the committed changes.
• FelixClouse added a subscriber: • FelixClouse.Jan 7 2016, 6:57 AM
This comment was removed by epriestley.
epriestley added a comment.Jan 7 2016, 11:01 AM

Wow, our first spam!

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
webroot/
rsrc/
css/
phui/
1 line

Diff 25663

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-property-list-view.css

Loading...
Phabricator · Built by Phacility