Page MenuHomePhabricator

Add a "Review" status to Phortune
ClosedPublic

Authored by epriestley on Oct 10 2014, 4:12 PM.
Tags
None
Referenced Files
F15522141: D10675.id25634.diff
Sun, Apr 20, 6:08 PM
F15520946: D10675.id25637.diff
Sun, Apr 20, 9:29 AM
F15518512: D10675.id25637.diff
Sat, Apr 19, 2:06 PM
F15517667: D10675.id.diff
Sat, Apr 19, 7:38 AM
F15514629: D10675.diff
Fri, Apr 18, 4:05 AM
F15486029: D10675.id25637.diff
Thu, Apr 10, 4:27 AM
F15452783: D10675.diff
Sat, Mar 29, 7:14 AM
F15430604: D10675.id25634.diff
Mon, Mar 24, 8:25 AM
Subscribers

Details

Summary

Ref T2787. Allow merchants to flag orders for review. For now, all orders are flagged for review. Eventually, I could imagine Herald rules for coarse things (e.g., require review of all orders over $1,000, or require review of all orders by users not on a whitelist) and maybe examining fraud data for the providers which support it.

Test Plan

Screen_Shot_2014-10-10_at_9.12.21_AM.png (843×1 px, 134 KB)

Diff Detail

Repository
rP Phabricator
Branch
fund1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phortune/storage/PhortuneCart.php:168XHP16TODO Comment
Advicesrc/applications/phortune/storage/PhortuneCart.php:202XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 2795
Build 2799: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add a "Review" status to Phortune.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 10 2014, 6:14 PM
This revision was automatically updated to reflect the committed changes.