Ref T2787. When Paypal comes back to us with funds on hold, dead-end the transaction but handle it properly.
Generally, smooth out the user interaction on weird states.
Implement refudnds/cancels for Paypal.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T2787: Build Phortune into a real accounts/billing application
- Commits
- Restricted Diffusion Commit
rP2a2fb62229dc: Add a HOLD state to Phortune and handle unusual states better
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- fund23
- Lint
Lint Passed Severity Location Code Message Advice src/applications/phortune/controller/PhortuneCartCancelController.php:160 XHP16 TODO Comment Advice src/applications/phortune/controller/PhortuneCartUpdateController.php:25 XHP16 TODO Comment Advice src/applications/phortune/provider/PhortunePayPalPaymentProvider.php:371 XHP16 TODO Comment Advice src/applications/phortune/provider/PhortunePayPalPaymentProvider.php:420 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 2787 Build 2791: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
An idea for later mayhaps inline.
| src/applications/phortune/controller/PhortuneCartViewController.php | ||
|---|---|---|
| 47 | Ideally 'contact the merchant' is a link | |
Comment Actions
Yeah, I'm not sure where I want to go with that. I figure we're going to be the only ones using this for a while and it's well documented how to get in touch with us, but I could imagine some more formal system down the road.