Differential D10659

Allow setting of "required":false in CustomFields
ClosedPublic
Actions

Authored by chad on Oct 7 2014, 11:24 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6265: required:false custom text fields are still listed as required in the edit page

Commits

Restricted Diffusion Commit
rP91549bb81d3b: Allow setting of "required":false in CustomFields

Summary

Fixes T6265, allows you to pass required:false as a parameter.

Test Plan

Add required:false to a field, no longer see "Required"

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2773
Build 2777: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 25597.Oct 7 2014, 11:24 PM

chad retitled this revision from to Allow setting of "required":false in CustomFields.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

chad added a task: T6265: required:false custom text fields are still listed as required in the edit page.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptOct 7 2014, 11:24 PM

Harbormaster completed remote builds in B2773: Diff 25597.Oct 7 2014, 11:25 PM

epriestley accepted this revision.Oct 7 2014, 11:47 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Oct 7 2014, 11:47 PM

Closed by commit rP91549bb81d3b: Allow setting of "required":false in CustomFields (authored by chad, committed by chad).Oct 7 2014, 11:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

customfield/

standard/

PhabricatorStandardCustomField.php

6 lines

Diff 25597

View Options

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php

Allow setting of "required":false in CustomFieldsClosedPublicActions