Page MenuHomePhabricator

Give WePay complete payment logic in Phortune
ClosedPublic

Authored by epriestley on Oct 6 2014, 7:02 PM.
Tags
None
Referenced Files
F14838812: D10639.id.diff
Fri, Jan 31, 6:26 PM
Unknown Object (File)
Sat, Jan 25, 1:27 PM
Unknown Object (File)
Thu, Jan 23, 5:17 PM
Unknown Object (File)
Thu, Jan 23, 5:17 PM
Unknown Object (File)
Thu, Jan 23, 5:17 PM
Unknown Object (File)
Thu, Jan 23, 5:17 PM
Unknown Object (File)
Tue, Jan 21, 11:21 AM
Unknown Object (File)
Sat, Jan 18, 4:38 AM
Subscribers

Details

Summary

Ref T2787. This doesn't get all the edge cases quite correct, but is generally a safe, complete payment workflow:

  • Shares the actual charging state logic.
  • Makes it appropriately stateful with locking and transactions.
  • Gets the main flow correct.
  • Detects failure cases, just tends to blow up rather than help the user resolve them.
Test Plan
  • Charged with WePay.
  • Charged with Infinite Free Money.
  • Resumed an abandoned cart.
  • Hit all failure states where we just dead-end the cart. Not ideal, but (seemingly) complete/safe/correct.

Diff Detail

Repository
rP Phabricator
Branch
fund5
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/phortune/provider/PhortuneWePayPaymentProvider.php:209XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 2751
Build 2755: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Give WePay complete payment logic in Phortune.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 6 2014, 8:02 PM
This revision was automatically updated to reflect the committed changes.