Page MenuHomePhabricator
Differential D10624

Make execution order of Herald rules explicit
ClosedPublic
Actions

Authored by epriestley on Oct 2 2014, 4:04 PM.
Tags
None
Referenced Files
F13181885: D10624.id25505.diff
Thu, May 9, 4:33 PM
Unknown Object (File)
Tue, May 7, 5:49 AM
Unknown Object (File)
Fri, May 3, 3:32 AM
Unknown Object (File)
Wed, May 1, 9:05 PM
Unknown Object (File)
Mon, Apr 29, 3:22 PM
Unknown Object (File)
Sun, Apr 28, 12:22 AM
Unknown Object (File)
Wed, Apr 24, 11:15 PM
Unknown Object (File)
Thu, Apr 11, 7:50 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6211: Make Herald rule execution order explicitly defined
Commits
Restricted Diffusion Commit
rP5f8280506862: Make execution order of Herald rules explicit
Summary

Fixes T6211. This gives Herald rules an explicit execution order, which seems generally good. See some discussion on T6211 and inline.

Test Plan
  • Added unit test.
  • Dry ran rules and saw rules appear in the expected order in the transcript.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25505.Oct 2 2014, 4:04 PM
epriestley retitled this revision from to Make execution order of Herald rules explicit.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6211: Make Herald rule execution order explicitly defined.
Herald added a subscriber: epriestley. · View Herald TranscriptOct 2 2014, 4:04 PM
Harbormaster completed remote builds in B2722: Diff 25505.Oct 2 2014, 4:05 PM
btrahan accepted this revision.Oct 2 2014, 4:39 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 2 2014, 4:39 PM
Closed by commit rP5f8280506862: Make execution order of Herald rules explicit (authored by epriestley, committed by epriestley).Oct 2 2014, 4:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
herald/
engine/
2 lines
storage/
36 lines
__tests__/
41 lines

Diff 25510

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/herald/engine/HeraldEngine.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
View Options

src/applications/herald/storage/__tests__/HeraldRuleTestCase.php

Loading...
Phabricator · Built by Phacility