Page MenuHomePhabricator

Purge readthrough caches before applying schema adjustments
ClosedPublic

Authored by epriestley on Oct 1 2014, 5:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 8:01 PM
Unknown Object (File)
Tue, Dec 10, 12:18 AM
Unknown Object (File)
Sun, Dec 8, 9:23 AM
Unknown Object (File)
Thu, Nov 28, 1:50 AM
Unknown Object (File)
Wed, Nov 27, 4:24 PM
Unknown Object (File)
Mon, Nov 25, 2:56 PM
Unknown Object (File)
Thu, Nov 21, 2:39 AM
Unknown Object (File)
Nov 16 2024, 8:40 PM
Subscribers

Details

Summary

Ref T1191. The bulk of the slowness in T1191 is copying tables. In some cases, we can't avoid this, but we have various readthrough caches which may be very large and are safe to drop, and dropping them is very quick (much less than 1 second). In particular, dropping the changeset_parse_cache made the process at least ~8 minutes faster on secure.phabricator.com (I killed it after 8 minutes, so I'm not sure what the real number is).

Test Plan

Ran bin/storage adjust and saw it drop caches before applying adjustments.

Diff Detail

Repository
rP Phabricator
Branch
utf6
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2710
Build 2714: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Purge readthrough caches before applying schema adjustments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2014, 7:14 PM
This revision was automatically updated to reflect the committed changes.