Page MenuHomePhabricator
Differential D10615

Truncate very old, overlong Maniphest mail keys
ClosedPublic
Actions

Authored by epriestley on Oct 1 2014, 5:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 7, 11:34 PM
Unknown Object (File)
Fri, Feb 7, 11:34 PM
Unknown Object (File)
Fri, Feb 7, 11:34 PM
Unknown Object (File)
Thu, Jan 30, 12:47 AM
Unknown Object (File)
Tue, Jan 28, 9:54 AM
Unknown Object (File)
Thu, Jan 23, 5:10 PM
Unknown Object (File)
Thu, Jan 23, 5:10 PM
Unknown Object (File)
Thu, Jan 23, 5:10 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1191: Comments are truncated at first non-base-plane character
Commits
Restricted Diffusion Commit
rP3a644cf6cc22: Truncate very old, overlong Maniphest mail keys
Summary

Ref T1191. Long ago, Maniphest generated with 40-character mail keys. These prevent the migration to bytes20. We had about 300 of these on secure.phabricator.com from several years ago.

Just truncate them. This adjusts reply-to addresses, but it's very likely that none are relevant anymore.

Test Plan

Ran migration on secure.phabricator.com to truncate keys.

Diff Detail

Repository
rP Phabricator
Branch
utf5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2709
Build 2713: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25484.Oct 1 2014, 5:01 PM
epriestley retitled this revision from to Truncate very old, overlong Maniphest mail keys.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1191: Comments are truncated at first non-base-plane character.
Herald added a subscriber: epriestley. · View Herald TranscriptOct 1 2014, 5:01 PM
Harbormaster completed remote builds in B2709: Diff 25484.Oct 1 2014, 5:02 PM
btrahan accepted this revision.Oct 1 2014, 7:13 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 1 2014, 7:13 PM
Closed by commit rP3a644cf6cc22: Truncate very old, overlong Maniphest mail keys (authored by epriestley, committed by epriestley).Oct 1 2014, 7:44 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
2 lines

Diff 25484

View Options

resources/sql/autopatches/20141001.schema.02.taskmail.sql

Loading...
Phabricator · Built by Phacility