Differential D10593

Mark questionable column nullability for later
ClosedPublic
Actions

Authored by epriestley on Sep 27 2014, 11:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 3, 7:24 AM

	Unknown Object (File)
	Sat, Nov 30, 4:55 AM

	Unknown Object (File)
	Mon, Nov 25, 8:46 AM

	Unknown Object (File)
	Thu, Nov 21, 12:43 PM

	Unknown Object (File)
	Nov 17 2024, 11:48 AM

	Unknown Object (File)
	Nov 1 2024, 1:27 PM

	Unknown Object (File)
	Oct 31 2024, 12:12 PM

	Unknown Object (File)
	Oct 24 2024, 2:47 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character
T6203: Adjust nullability of various questionable columns

Commits

Restricted Diffusion Commit
rP03519c53bbcc: Mark questionable column nullability for later

Summary

Ref T1191. Ref T6203. While generating expected schemata, I ran into these columns which seem to have sketchy nullability.

Mark most of them for later resolution (T6203). They work fine today and don't need to block T1191. Changing them can break the application, so we can't autofix them.
Forgive a couple of them that are sort-of reasonable or going to get wiped out.

Test Plan

Saw 94 remaining warnings.

Diff Detail

Repository

Branch

utfx20

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2702
Build 2706: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25429.Sep 27 2014, 11:48 PM

epriestley retitled this revision from to Mark questionable column nullability for later.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T6203: Adjust nullability of various questionable columns, T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 27 2014, 11:48 PM

Harbormaster completed remote builds in B2682: Diff 25429.Sep 27 2014, 11:49 PM

hach-que added a subscriber: hach-que.Sep 28 2014, 12:33 AM

hach-que added inline comments.

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php
36	This is null because of previously existing build steps in the DB before name was added. In this case, null means "fallback to the implementation name". In order to remove this null, we'd need to run a migration to fill in all the null values with the implementation name.

btrahan accepted this revision.Sep 30 2014, 4:53 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Sep 30 2014, 4:53 PM

Add context from @hach-que to comment.

Harbormaster completed remote builds in B2702: Diff 25467.Oct 1 2014, 2:57 PM

Closed by commit rP03519c53bbcc: Mark questionable column nullability for later (authored by epriestley, committed by epriestley).Oct 1 2014, 2:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

schema/

PhabricatorConfigStorageSchema.php

2 lines

differential/

storage/

DifferentialChangeset.php

8 lines

DifferentialDiff.php

8 lines

DifferentialRevision.php

2 lines

harbormaster/

storage/

HarbormasterObject.php

2 lines

HarbormasterSchemaSpec.php

6 lines

build/

HarbormasterBuildLog.php

10 lines

HarbormasterBuildTarget.php

5 lines

configuration/

HarbormasterBuildStep.php

7 lines

herald/

storage/

5 lines

maniphest/

storage/

ManiphestTask.php

5 lines

metamta/

storage/

PhabricatorMetaMTAMail.php

5 lines

paste/

storage/

PhabricatorPaste.php

4 lines

phame/

storage/

7 lines

12 lines

phriction/

storage/

PhrictionContent.php

5 lines

ponder/

storage/

PonderAnswer.php

5 lines

PonderQuestion.php

5 lines

project/

storage/

PhabricatorProject.php

7 lines

releeph/

storage/

ReleephRequest.php

6 lines

repository/

storage/

PhabricatorRepositoryRefCursor.php

5 lines

settings/

storage/

PhabricatorUserSSHKey.php

9 lines

infrastructure/

daemon/

workers/

storage/

PhabricatorWorkerActiveTask.php

7 lines

Diff 25467

src/applications/config/schema/PhabricatorConfigStorageSchema.php

Loading...

src/applications/differential/storage/DifferentialChangeset.php

Loading...

src/applications/differential/storage/DifferentialDiff.php

Loading...

src/applications/differential/storage/DifferentialRevision.php

Loading...

src/applications/harbormaster/storage/HarbormasterObject.php

Loading...

src/applications/harbormaster/storage/HarbormasterSchemaSpec.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuildLog.php

Loading...

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

Loading...

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

Loading...

src/applications/herald/storage/HeraldRule.php

Loading...

src/applications/maniphest/storage/ManiphestTask.php

Loading...

src/applications/metamta/storage/PhabricatorMetaMTAMail.php

Loading...

src/applications/paste/storage/PhabricatorPaste.php

Loading...

src/applications/phame/storage/PhameBlog.php

Loading...

src/applications/phame/storage/PhamePost.php

Loading...

src/applications/phriction/storage/PhrictionContent.php

Loading...

src/applications/ponder/storage/PonderAnswer.php

Loading...

src/applications/ponder/storage/PonderQuestion.php

Loading...

src/applications/project/storage/PhabricatorProject.php

Loading...

src/applications/releeph/storage/ReleephRequest.php

Loading...

src/applications/repository/storage/PhabricatorRepositoryRefCursor.php

Loading...

src/applications/settings/storage/PhabricatorUserSSHKey.php

Loading...

src/infrastructure/daemon/workers/storage/PhabricatorWorkerActiveTask.php

Loading...