Page MenuHomePhabricator
Differential D10588

Generate expected schemata for Fact, Owners, Herald and Diviner
ClosedPublic
Actions

Authored by epriestley on Sep 27 2014, 9:14 PM.
Tags
None
Referenced Files
F13227514: D10588.id25423.diff
Mon, May 20, 3:53 AM
F13213819: D10588.diff
Fri, May 17, 8:06 AM
F13199702: D10588.id25426.diff
Mon, May 13, 5:16 PM
F13198590: D10588.id.diff
Mon, May 13, 8:10 AM
F13184663: D10588.id25462.diff
Fri, May 10, 9:46 PM
F13174945: D10588.id25426.diff
Wed, May 8, 2:09 AM
Unknown Object (File)
Tue, May 7, 9:09 AM
Unknown Object (File)
Mon, May 6, 6:18 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1191: Comments are truncated at first non-base-plane character
Commits
Restricted Diffusion Commit
rPdc8b2ae6d226: Generate expected schemata for Fact, Owners, Herald and Diviner
Summary

Ref T1191. Notable:

  • HeraldApplyTranscript is not actually a DAO and has no table (it is serialized into HeraldTranscript).
Test Plan

Down to fewer than 300 issues.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25423.Sep 27 2014, 9:14 PM
epriestley retitled this revision from to Generate expected schemata for Fact, Owners, Herald and Diviner.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1191: Comments are truncated at first non-base-plane character.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 27 2014, 9:14 PM
Harbormaster completed remote builds in B2676: Diff 25423.Sep 27 2014, 9:15 PM
epriestley updated this revision to Diff 25426.Sep 27 2014, 11:10 PM
  • Restore implicitly removed set...() methods.
Harbormaster completed remote builds in B2679: Diff 25426.Sep 27 2014, 11:11 PM
btrahan accepted this revision.Sep 30 2014, 4:47 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 4:47 PM
Closed by commit rPdc8b2ae6d226: Generate expected schemata for Fact, Owners, Herald and Diviner (authored by epriestley, committed by epriestley).Oct 1 2014, 2:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25462

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveAtom.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveBook.php

Loading...
View Options

src/applications/diviner/storage/DivinerLiveSymbol.php

Loading...
View Options

src/applications/diviner/storage/DivinerSchemaSpec.php

Loading...
View Options

src/applications/fact/storage/PhabricatorFactAggregate.php

Loading...
View Options

src/applications/fact/storage/PhabricatorFactCursor.php

Loading...
View Options

src/applications/fact/storage/PhabricatorFactRaw.php

Loading...
View Options

src/applications/fact/storage/PhabricatorFactSchemaSpec.php

Loading...
View Options

src/applications/herald/storage/HeraldAction.php

Loading...
View Options

src/applications/herald/storage/HeraldCondition.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
View Options

src/applications/herald/storage/HeraldRuleEdit.php

Loading...
View Options

src/applications/herald/storage/HeraldSchemaSpec.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldApplyTranscript.php

Loading...
View Options

src/applications/herald/storage/transcript/HeraldTranscript.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersOwner.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPath.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersSchemaSpec.php

Loading...
Phabricator · Built by Phacility