Page MenuHomePhabricator

Fix footer on mobile/nav pages
ClosedPublic

Authored by chad on Sep 30 2014, 6:55 PM.
Tags
None
Referenced Files
F17697170: D10609.diff
Tue, Jul 15, 6:10 PM
Unknown Object (File)
Mon, Jun 16, 9:31 AM
Unknown Object (File)
Mon, Jun 16, 7:39 AM
Unknown Object (File)
Jun 15 2025, 4:20 PM
Unknown Object (File)
Jun 15 2025, 8:07 AM
Unknown Object (File)
May 10 2025, 8:04 AM
Unknown Object (File)
May 6 2025, 9:36 PM
Unknown Object (File)
Apr 17 2025, 5:53 PM
Subscribers

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP97dd3dcb372a: Fix footer on mobile/nav pages
Summary

We should only move the footer over on desktops, where the sidenav is still present.

Test Plan

Test Mobile, Tablet, Desktop breakpoints on Herald.

Diff Detail

Repository
rP Phabricator
Branch
mobile-footer
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2700
Build 2704: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Fix footer on mobile/nav pages.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 30 2014, 7:29 PM
This revision was automatically updated to reflect the committed changes.