Provide `bin/storage quickstart` to automate generation of `quickstart.sql`
ClosedPublic
Actions

Authored by epriestley on Sep 28 2014, 8:35 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T1191: Comments are truncated at first non-base-plane character

Commits

Restricted Diffusion Commit
rP0d7489da79bc: Provide `bin/storage quickstart` to automate generation of `quickstart.sql`

Summary

Ref T1191. Currently, the quickstart.sql gets generated in a pretty manual fashion. This is a pain, and will become more of a pain in the world of utf8mb4.

Provide a workflow which does upgrade + adjust + dump + destroy, then massages the output to produce a workable quickstart.sql.

Test Plan

Inspected output; I'll test this more throughly before actually generating a new quickstart, but that's some ways away.

Diff Detail

Repository

rP Phabricator

Branch

utfx27

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 2693
Build 2697: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	0 ms	testMySQLAgreesWithUsAboutBMP
	0 ms	testRejectMySQLBMPQueries
	0 ms	testApplicationsInstalled
	0 ms	testCelerityMaps
	0 ms	testConnectionFailures
		View Full Test Results (2 Failed · 11 Passed)

Event Timeline

epriestley updated this revision to Diff 25440.Sep 28 2014, 8:35 PM

epriestley retitled this revision from to Provide `bin/storage quickstart` to automate generation of `quickstart.sql`.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T1191: Comments are truncated at first non-base-plane character.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 28 2014, 8:35 PM

Harbormaster completed remote builds in B2693: Diff 25440.Sep 28 2014, 8:36 PM

Harbormaster completed remote builds in B2693: Diff 25440.Sep 30 2014, 5:10 AM

This'll be cool.

resources/sql/patches/065.sshkeys.sql
7	sneaking this in here?

This revision is now accepted and ready to land.Sep 30 2014, 5:08 PM

epriestley added inline comments.Sep 30 2014, 5:13 PM

resources/sql/patches/065.sshkeys.sql
7	When reapplying the patches with `--no-quickstart` (which normal users will never do), this patch failed, probably because of MySQL version differences. This makes it succeed; the column type will be adjusted later if necessary.