Page MenuHomePhabricator
Differential D10544

Increase Drydock worker time to 24 hours
ClosedPublic
Actions

Authored by hach-que on Sep 23 2014, 11:26 PM.
Tags
None
Referenced Files
F14398806: D10544.diff
Sun, Dec 22, 2:56 PM
Unknown Object (File)
Fri, Dec 20, 12:09 AM
Unknown Object (File)
Tue, Dec 17, 9:02 PM
Unknown Object (File)
Sat, Dec 7, 12:12 PM
Unknown Object (File)
Wed, Dec 4, 7:26 AM
Unknown Object (File)
Nov 19 2024, 10:09 AM
Unknown Object (File)
Oct 17 2024, 9:33 PM
Unknown Object (File)
Oct 14 2024, 5:40 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T2015: Implement Drydock
Commits
Restricted Diffusion Commit
rP427712306076: Increase Drydock worker time to 24 hours
Summary

Ref T2015. This increases the Drydock worker lease time to 24 hours. We noticed that some leases took longer than 2 hours when leasing from AWS (the actual resource was successfully leased at around 2 hours, 19 minutes).

24 hours should be plenty enough time to actually lease anything from EC2 (or any other leases during builds).

Test Plan

Have not yet tested this.

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2616
Build 2620: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 25329.Sep 23 2014, 11:26 PM
hach-que retitled this revision from to Increase Drydock worker time to 24 hours.
hach-que updated this object.
hach-que edited the test plan for this revision. (Show Details)
hach-que added a reviewer: epriestley.
hach-que added a task: T2015: Implement Drydock.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptSep 23 2014, 11:26 PM
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2616: Diff 25329.Sep 23 2014, 11:27 PM
epriestley accepted this revision.Sep 24 2014, 9:06 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 24 2014, 9:06 PM
Closed by commit rP427712306076: Increase Drydock worker time to 24 hours (authored by hach-que, committed by hach-que).Sep 24 2014, 11:46 PM
This revision was automatically updated to reflect the committed changes.
hach-que mentioned this in D10304: [drydock/core] Implement resource constraints and correct locking mechanisms with yielding for Drydock.Aug 24 2015, 7:48 PM

Revision Contents
Changeset List

PathSize
src/
applications/
drydock/
worker/
4 lines

Diff 25329

View Options

src/applications/drydock/worker/DrydockAllocatorWorker.php

Loading...
Phabricator · Built by Phacility