Page MenuHomePhabricator
Differential D10501

Generate reasonable expected schemata for Cache tables
ClosedPublic
Actions

Authored by epriestley on Sep 15 2014, 7:42 PM.
Tags
None
Referenced Files
F13170664: D10501.diff
Tue, May 7, 9:35 AM
Unknown Object (File)
Mon, May 6, 7:03 PM
Unknown Object (File)
Sat, May 4, 10:11 AM
Unknown Object (File)
Fri, May 3, 9:27 AM
Unknown Object (File)
Wed, May 1, 9:46 AM
Unknown Object (File)
Fri, Apr 26, 3:49 PM
Unknown Object (File)
Thu, Apr 25, 8:24 AM
Unknown Object (File)
Thu, Apr 25, 3:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1191: Comments are truncated at first non-base-plane character
Commits
Restricted Diffusion Commit
rP9b63f84ff93f: Generate reasonable expected schemata for Cache tables
Summary

Ref T1191. Notable:

  • Rename blob to bytes for clarity.
  • Introduce raw schema specs.
Test Plan

See screenshots.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 25235.Sep 15 2014, 7:42 PM
epriestley retitled this revision from to Generate reasonable expected schemata for Cache tables.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1191: Comments are truncated at first non-base-plane character.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 15 2014, 7:42 PM
epriestley added a comment.Sep 15 2014, 7:43 PM

Screen_Shot_2014-09-15_at_12.41.14_PM.png (1×1 px, 208 KB)

Screen_Shot_2014-09-15_at_12.41.16_PM.png (1×1 px, 202 KB)

Harbormaster completed remote builds in B2549: Diff 25235.Sep 15 2014, 7:43 PM
btrahan accepted this revision.Sep 16 2014, 6:40 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 16 2014, 6:40 PM
Closed by commit rP9b63f84ff93f: Generate reasonable expected schemata for Cache tables (authored by epriestley, committed by epriestley).Sep 18 2014, 3:36 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
cache/
storage/
31 lines
8 lines
config/
schema/
7 lines
35 lines
infrastructure/
storage/
lisk/
2 lines

Diff 25271

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/cache/storage/PhabricatorCacheSchemaSpec.php

Loading...
View Options

src/applications/cache/storage/PhabricatorMarkupCache.php

Loading...
View Options

src/applications/config/schema/PhabricatorConfigColumnSchema.php

Loading...
View Options

src/applications/config/schema/PhabricatorConfigSchemaSpec.php

Loading...
View Options

src/infrastructure/storage/lisk/LiskDAO.php

Loading...
Phabricator · Built by Phacility