Page MenuHomePhabricator
Differential D10487

Differential - label unit / lint results from the commit diff as not applicable
ClosedPublic
Actions

Authored by btrahan on Sep 12 2014, 5:22 PM.
Tags
None
Referenced Files
F14394213: D10487.diff
Sun, Dec 22, 1:47 AM
F14393654: D10487.id25210.diff
Sun, Dec 22, 12:29 AM
Unknown Object (File)
Mon, Dec 16, 9:21 PM
Unknown Object (File)
Wed, Dec 11, 5:42 PM
Unknown Object (File)
Thu, Dec 5, 9:24 PM
Unknown Object (File)
Wed, Dec 4, 5:38 AM
Unknown Object (File)
Sat, Nov 30, 5:46 PM
Unknown Object (File)
Fri, Nov 29, 3:20 PM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Love" token, awarded by hach-que.

Details

Reviewers
epriestley
Maniphest Tasks
T5536: Automatic diff should be more clearly called out in the UI
Commits
Restricted Diffusion Commit
rP936ee22de1b8: Differential - label unit / lint results from the commit diff as not applicable
Summary

Fixes T5536. Some bonus pht in there.

Test Plan

made a diff hovered over the stars and saw my new text.

Diff Detail

Repository
rP Phabricator
Branch
T5536
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2526
Build 2530: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25210.Sep 12 2014, 5:22 PM
btrahan added a task: T5536: Automatic diff should be more clearly called out in the UI.
btrahan retitled this revision from to Differential - label unit / lint results from the commit diff as not applicable.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 12 2014, 5:22 PM
Harbormaster completed remote builds in B2526: Diff 25210.Sep 12 2014, 5:23 PM
epriestley accepted this revision.Sep 14 2014, 2:04 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Sep 14 2014, 2:04 PM
hach-que awarded a token.Sep 14 2014, 3:03 PM
Closed by commit rP936ee22de1b8: Differential - label unit / lint results from the commit diff as not applicable (authored by btrahan, committed by btrahan).Sep 16 2014, 7:07 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
constants/
1 line
1 line
customfield/
3 lines
2 lines
view/
31 lines
repository/
worker/
commitmessageparser/
4 lines

Diff 25210

View Options

src/applications/differential/constants/DifferentialLintStatus.php

Loading...
View Options

src/applications/differential/constants/DifferentialUnitStatus.php

Loading...
View Options

src/applications/differential/customfield/DifferentialLintField.php

Loading...
View Options

src/applications/differential/customfield/DifferentialUnitField.php

Loading...
View Options

src/applications/differential/view/DifferentialRevisionUpdateHistoryView.php

Loading...
View Options

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php

Loading...
Phabricator · Built by Phacility