Add `ui.footer-items` to add a custom page footer
ClosedPublic
Actions

Authored by epriestley on Sep 10 2014, 8:19 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T6052: Legal links visible in all pages

Commits

Restricted Diffusion Commit
rPd3cd9115f949: Add `ui.footer-items` to add a custom page footer

Summary

Fixes T6052. Allow installs to link to legal documents, etc., in the page footer.

Test Plan

Configured a footer.
Viewed workboards (no footer).
Viewed Conpherence (no apparent disruption, I think everything z-indexes over the footer).
Viewed stuff on mobile (seems OK).
Viewed login page (saw footer).

Screen_Shot_2014-09-10_at_1.03.36_PM.png (771×1 px, 130 KB)

Diff Detail

Repository

rP Phabricator

Branch

footer

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2497
Build 2501: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25169.Sep 10 2014, 8:19 PM

epriestley retitled this revision from to Add `ui.footer-items` to add a custom page footer.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

epriestley added a task: T6052: Legal links visible in all pages.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 10 2014, 8:19 PM

Harbormaster completed remote builds in B2495: Diff 25169.Sep 10 2014, 8:19 PM

Are you OK adding this, I would be fine punting since it means we have to support it for eons.

chad added inline comments.Sep 10 2014, 9:04 PM

webroot/rsrc/css/application/base/standard-page-view.css
18	I'd probably add 16px of margin to not have a line in the gutter, then padding of 8px 0; ? I think?

Oh I see your comment on the task. Carry on.

This revision is now accepted and ready to land.Sep 10 2014, 9:05 PM

If we pull the line out of the gutter, it will still run into the navigation menu on the left. Is that OK? Let me screenshot...

Page with nav, with pulled-out-of-gutter spacing (direct contact on left side):

Screen_Shot_2014-09-10_at_2.11.41_PM.png (739×1 px, 218 KB)

Page without nav (no contact with either gutter):

Screen_Shot_2014-09-10_at_2.11.56_PM.png (739×1 px, 142 KB)

I think that's fine, but it's a maybe not-obvious consequence.

Could drop the line too

After poking around, it looks a bit odd on some pages to me without the line, but feel free to counterdiff this if you want to play with it. I don't have super strong feelings either way.