Page MenuHomePhabricator
Differential D10415

Use %s, not %d, to encode a 64-bit integer for a query
ClosedPublic
Actions

Authored by epriestley on Sep 4 2014, 6:02 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 10, 2:46 AM
Unknown Object (File)
Fri, May 9, 7:33 PM
Unknown Object (File)
Tue, Apr 29, 5:20 AM
Unknown Object (File)
Sun, Apr 27, 7:14 PM
Unknown Object (File)
Sun, Apr 27, 5:14 AM
Unknown Object (File)
Sun, Apr 27, 5:12 AM
Unknown Object (File)
Sat, Apr 26, 3:26 PM
Unknown Object (File)
Wed, Apr 23, 3:49 PM
View All Files
Subscribers
epriestley
Tokens
"Grey Medal" token, awarded by btrahan.

Details

Reviewers
btrahan
Maniphest Tasks
T5982: Notifications: "Mark all Read" not clearing unread notifications list
Commits
Restricted Diffusion Commit
rP4d3cc7b28dd1: Use %s, not %d, to encode a 64-bit integer for a query
Summary

Fixes T5982. Probably. I'm just guessing here but like 95% sure this will fix it and 99% sure it won't hurt/break anything.

Test Plan

Still works on my 64-bit install, for what little that's worth.

Diff Detail

Repository
rP Phabricator
Branch
notif
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2432
Build 2436: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25058.Sep 4 2014, 6:02 PM
epriestley retitled this revision from to Use %s, not %d, to encode a 64-bit integer for a query.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5982: Notifications: "Mark all Read" not clearing unread notifications list.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 4 2014, 6:02 PM
Harbormaster completed remote builds in B2432: Diff 25058.Sep 4 2014, 6:03 PM
epriestley updated this revision to Diff 25059.Sep 4 2014, 6:03 PM
  • Use getStr() instead of getInt() for good measure.

iiam

Harbormaster completed remote builds in B2433: Diff 25059.Sep 4 2014, 6:04 PM
btrahan accepted this revision.Sep 4 2014, 6:38 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2014, 6:38 PM
btrahan awarded a token.Sep 4 2014, 6:41 PM
epriestley closed this revision.Sep 4 2014, 7:47 PM
epriestley updated this revision to Diff 25062.

Closed by commit rP4d3cc7b28dd1 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
notification/
controller/
2 lines

Diff 25058

View Options

src/applications/notification/controller/PhabricatorNotificationClearController.php

Loading...
Phabricator · Built by Phacility