Page MenuHomePhabricator

Allow Passphrase to store empty secrets
ClosedPublic

Authored by epriestley on Sep 4 2014, 5:55 PM.
Tags
None
Referenced Files
F14766176: D10414.id25065.diff
Thu, Jan 23, 4:14 PM
F14766175: D10414.id25057.diff
Thu, Jan 23, 4:14 PM
F14766173: D10414.id.diff
Thu, Jan 23, 4:14 PM
F14766171: D10414.diff
Thu, Jan 23, 4:14 PM
Unknown Object (File)
Fri, Jan 17, 8:44 PM
Unknown Object (File)
Fri, Dec 27, 6:35 AM
Unknown Object (File)
Dec 9 2024, 3:48 AM
Unknown Object (File)
Nov 19 2024, 12:56 PM
Subscribers

Details

Summary

Fixes T6001. We currently don't allow empty secrets, but accounts with no password are occasionally used in the wild.

Test Plan
  • Created a credential with an empty secret.
  • Revealed secret, saw empty message.
  • Edited it (no form changes), saw secret unchanged.
  • Changed it to a nonempty secret.
  • Revealed nonempty secret.
  • Edited it (no form changes), saw secret unchanged.

Diff Detail

Repository
rP Phabricator
Branch
nosecret
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2431
Build 2435: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Allow Passphrase to store empty secrets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2014, 7:28 PM
epriestley updated this revision to Diff 25065.

Closed by commit rPa6296a64a457 (authored by @epriestley).