Page MenuHomePhabricator
Differential D10413

Add a configuration warning when `memory_limit` will limit file uploads
ClosedPublic
Actions

Authored by epriestley on Sep 4 2014, 5:30 PM.
Tags
None
Referenced Files
F14970953: D10413.diff
Sun, Feb 16, 11:40 AM
Unknown Object (File)
Fri, Feb 7, 10:57 PM
Unknown Object (File)
Fri, Feb 7, 10:57 PM
Unknown Object (File)
Fri, Feb 7, 10:57 PM
Unknown Object (File)
Fri, Feb 7, 9:25 AM
Unknown Object (File)
Thu, Feb 6, 9:20 PM
Unknown Object (File)
Thu, Jan 30, 6:22 AM
Unknown Object (File)
Thu, Jan 23, 4:14 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T6011: arc file upload fails with 502 error from Nginx reverse proxy
Commits
Restricted Diffusion Commit
rP8efea3abe958: Add a configuration warning when `memory_limit` will limit file uploads
Summary

Fixes T6011. See that task for discussion. We can detect when memory_limit will be the limiting factor for drag-and-drop uploads and warn administrators about it.

Test Plan

Fiddled configuration values and hit, then resolved, the issue.

Diff Detail

Repository
rP Phabricator
Branch
uplimit
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsupport/PhabricatorStartup.php:319XHP45PHP Compatibility
Unit
No Test Coverage
Build Status
Buildable 2430
Build 2434: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 25056.Sep 4 2014, 5:30 PM
epriestley retitled this revision from to Add a configuration warning when `memory_limit` will limit file uploads.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T6011: arc file upload fails with 502 error from Nginx reverse proxy.
Herald added a subscriber: epriestley. · View Herald TranscriptSep 4 2014, 5:30 PM
Harbormaster completed remote builds in B2430: Diff 25056.Sep 4 2014, 5:30 PM
btrahan accepted this revision.Sep 4 2014, 7:27 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Sep 4 2014, 7:27 PM
epriestley closed this revision.Sep 4 2014, 7:48 PM
epriestley updated this revision to Diff 25066.

Closed by commit rP8efea3abe958 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
config/
check/
59 lines
issue/
23 lines
view/
8 lines
support/
10 lines

Diff 25056

View Options

src/applications/config/check/PhabricatorSetupCheckStorage.php

Loading...
View Options

src/applications/config/issue/PhabricatorSetupIssue.php

Loading...
View Options

src/applications/config/view/PhabricatorSetupIssueView.php

Loading...
View Options

support/PhabricatorStartup.php

Loading...
Phabricator · Built by Phacility