Differential D10407

Maniphest - make custom fields always render last
ClosedPublic
Actions

Authored by btrahan on Sep 3 2014, 7:42 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T6029: "Projects" shows under custom fields on Tasks

Commits

Restricted Diffusion Commit
rPb2d596846059: Maniphest - make custom fields always render last

Summary

Fixes T6029. We should append custom fields last so they show up after things like projects, tokens, etc that render via UI events.

Test Plan

viewed a task with custom fields and projects was last

Diff Detail

Repository

rP Phabricator

Branch

T6029

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2420
Build 2424: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 25040.Sep 3 2014, 7:42 PM

btrahan added a task: T6029: "Projects" shows under custom fields on Tasks.

btrahan retitled this revision from to Maniphest - make custom fields always render last.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptSep 3 2014, 7:42 PM

Harbormaster completed remote builds in B2420: Diff 25040.Sep 3 2014, 7:42 PM

epriestley accepted this revision.Sep 3 2014, 7:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Sep 3 2014, 7:44 PM

Closed by commit rPb2d596846059 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

4 lines

Diff 25040

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Maniphest - make custom fields always render lastClosedPublicActions