Page MenuHomePhabricator
Differential D10368

Daemons - better handle rogue daemons from phd
ClosedPublic
Actions

Authored by btrahan on Aug 27 2014, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 4:49 PM
Unknown Object (File)
Sun, Nov 3, 1:15 AM
Unknown Object (File)
Sun, Nov 3, 1:01 AM
Unknown Object (File)
Oct 21 2024, 12:51 PM
Unknown Object (File)
Oct 15 2024, 12:50 PM
Unknown Object (File)
Oct 14 2024, 8:47 PM
Unknown Object (File)
Oct 14 2024, 12:10 PM
Unknown Object (File)
Oct 5 2024, 3:58 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T2374: Have `bin/phd stop` look for daemons and warn you about them, or nuke them with some flag
Commits
Restricted Diffusion Commit
rP2fdd7f0f3d2e: Daemons - better handle rogue daemons from phd
Summary

Ref T2374. While building D10367 I noticed that phd was finding rogue daemons way more than it should be. Re-jigger this code path so rogue daemons are checked for *after* we've dealt with known daemons. This keeps the logic pretty simple overall.

Test Plan

phd start; kill pid files; phd stop and get the right warning; phd stop --force and it kills the rogue demons. phd stop in normal conditions no longer reporting rogue daemons erroneously

Diff Detail

Repository
rP Phabricator
Branch
bug
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2367
Build 2371: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24952.Aug 27 2014, 6:31 PM
btrahan retitled this revision from to Daemons - better handle rogue daemons from phd.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
btrahan added a task: T2374: Have `bin/phd stop` look for daemons and warn you about them, or nuke them with some flag.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 27 2014, 6:31 PM
Harbormaster completed remote builds in B2367: Diff 24952.Aug 27 2014, 6:32 PM
epriestley accepted this revision.Aug 27 2014, 7:12 PM
epriestley edited edge metadata.

Ah, nice. I saw this too.

One other thing I hit is that bin/phd stop <pid> checks for rogues, but probably should not, since the user is trying to surgically stop a specific PID.

This revision is now accepted and ready to land.Aug 27 2014, 7:12 PM
btrahan updated this revision to Diff 24957.Aug 27 2014, 7:19 PM
btrahan edited edge metadata.

only show stop hint for rogue daemons if user did not specify $pids

btrahan closed this revision.Aug 27 2014, 7:20 PM
btrahan updated this revision to Diff 24959.

Closed by commit rP2fdd7f0f3d2e (authored by @btrahan).

Harbormaster completed remote builds in B2369: Diff 24957.Aug 27 2014, 7:20 PM

Revision Contents
Changeset List

PathSize
src/
applications/
daemon/
management/
28 lines

Diff 24952

View Options

src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php

Loading...
Phabricator · Built by Phacility