Daemons - add status of environment to daemon console, etc
ClosedPublic
Actions

Authored by btrahan on Aug 27 2014, 6:11 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5968: "Phabricator Daemons Need Restarting" is too difficult to understand/debug

Commits

Restricted Diffusion Commit
rPc2874945c87f: Daemons - add status of environment to daemon console, etc

Summary

Shows the UI everywhere. Also asort() the keys before calculating the environment hash as that is probably an issue for someone at some point we just don't need to have. Ref T5968.

Test Plan

Viewed the setup check and saw a link to the daemon console. Viewed the daemon console and saw the various stale config daemons. Clicked a daemon and saw a "stale config" header icon where expected. Restarted daemons and all of this went away.

Diff Detail

Repository

rP Phabricator

Branch

T5968

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2366
Build 2370: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24951.Aug 27 2014, 6:11 PM

btrahan added a task: T5968: "Phabricator Daemons Need Restarting" is too difficult to understand/debug.

btrahan retitled this revision from to Daemons - add status of environment to daemon console, etc.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 27 2014, 6:11 PM

Screen_Shot_2014-08-27_at_11.12.18_AM.png (1×2 px, 442 KB)

Screen_Shot_2014-08-27_at_11.12.28_AM.png (1×2 px, 509 KB)

Screen_Shot_2014-08-27_at_11.12.25_AM.png (1×2 px, 566 KB)

Harbormaster completed remote builds in B2366: Diff 24951.Aug 27 2014, 6:12 PM

Cool, I think this should help. One inline...

src/infrastructure/env/PhabricatorEnv.php
226	Now that I think about it, maybe `ksort` would be better here. I'm not sure `asort()` is stable if two keys have the same value, but we know the keys are all different.