Differential D10351

Remove setWorkingDirectory call on SFTP interface
ClosedPublic
Actions

Authored by hach-que on Aug 26 2014, 11:00 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPddfa5cbdf67f: Remove setWorkingDirectory call on SFTP interface

Summary

I derped on this; the SFTP interface doesn't have setWorkingDirectory because it implements DrydockFilesystemInterface and not DrydockCommandInterface. So when you use the Upload File build step, the daemon will crash due to an undefined method.

Test Plan

Tested on my live server.

Diff Detail

Repository

rP Phabricator

Branch

sftp-fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2347
Build 2351: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

hach-que updated this revision to Diff 24918.Aug 26 2014, 11:00 AM

hach-que retitled this revision from to Remove setWorkingDirectory call on SFTP interface.

hach-que updated this object.

hach-que edited the test plan for this revision. (Show Details)

hach-que added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 26 2014, 11:00 AM

Herald added subscribers: Korvin, epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2347: Diff 24918.Aug 26 2014, 11:01 AM

epriestley accepted this revision.Aug 26 2014, 4:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 26 2014, 4:01 PM

Closed by commit rPddfa5cbdf67f (authored by @hach-que).

Revision Contents
Changeset List

Path

Size

src/

applications/

drydock/

blueprint/

DrydockPreallocatedHostBlueprintImplementation.php

3 lines

Diff 24918

View Options

src/applications/drydock/blueprint/DrydockPreallocatedHostBlueprintImplementation.php

Remove setWorkingDirectory call on SFTP interfaceClosedPublicActions