Page MenuHomePhabricator
Differential D10349

Allow "Track Only" and "Autoclose" to accept regular expressions
ClosedPublic
Actions

Authored by epriestley on Aug 25 2014, 11:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 27, 2:12 PM
Unknown Object (File)
Tue, Dec 24, 9:35 AM
Unknown Object (File)
Sat, Dec 21, 12:16 PM
Unknown Object (File)
Sat, Dec 21, 9:13 AM
Unknown Object (File)
Wed, Dec 18, 3:23 AM
Unknown Object (File)
Thu, Dec 12, 2:31 PM
Unknown Object (File)
Sat, Dec 7, 12:02 PM
Unknown Object (File)
Thu, Dec 5, 10:28 AM
View All Files
Subscribers
epriestley
Tokens
"Love" token, awarded by sophiebits.

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP912b4c564d6f: Allow "Track Only" and "Autoclose" to accept regular expressions
Summary

Fixes T2564. See screenshot.

Test Plan

Screen_Shot_2014-08-25_at_4.08.09_PM.png (1×1 px, 177 KB)

  • Made a bunch of valid and invalid adjustments here and verified that the branches table showed autoclose state and branches consistent with the settings.

Diff Detail

Repository
rP Phabricator
Branch
regexpmatch
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2345
Build 2349: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24914.Aug 25 2014, 11:09 PM
epriestley retitled this revision from to Allow "Track Only" and "Autoclose" to accept regular expressions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 25 2014, 11:09 PM
Harbormaster completed remote builds in B2345: Diff 24914.Aug 25 2014, 11:10 PM
sophiebits awarded a token.Aug 25 2014, 11:38 PM
shrey added a subscriber: shrey.Aug 26 2014, 9:33 AM
shrey removed a subscriber: shrey.
epriestley updated this revision to Diff 24921.Aug 26 2014, 5:06 PM
  • Add validation checks for regex(...), quack(...), etc.
Harbormaster completed remote builds in B2349: Diff 24921.Aug 26 2014, 5:07 PM
btrahan accepted this revision.Aug 26 2014, 8:00 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 26 2014, 8:00 PM
epriestley closed this revision.Aug 26 2014, 8:29 PM
epriestley updated this revision to Diff 24927.

Closed by commit rP912b4c564d6f (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
152 lines
repository/
editor/
24 lines
storage/
43 lines

Diff 24914

View Options

src/applications/diffusion/controller/DiffusionRepositoryEditBranchesController.php

Loading...
View Options

src/applications/repository/editor/PhabricatorRepositoryEditor.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility