Page MenuHomePhabricator

Improve documentation and tooling around autoclose
ClosedPublic

Authored by epriestley on Aug 25 2014, 10:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 10:40 AM
Unknown Object (File)
Tue, Dec 17, 6:03 AM
Unknown Object (File)
Mon, Dec 9, 5:09 PM
Unknown Object (File)
Mon, Dec 9, 6:32 AM
Unknown Object (File)
Wed, Dec 4, 5:41 AM
Unknown Object (File)
Wed, Dec 4, 1:00 AM
Unknown Object (File)
Sat, Nov 30, 1:44 AM
Unknown Object (File)
Wed, Nov 27, 6:36 PM
Subscribers

Details

Summary

Fixes T4767. I believe 80% of this was actually caused by the author issue fixed in T5771, but this should help make the other 20% debuggable.

  • Record why we didn't autoclose a commit when we process it.
  • Show branch autoclose status in the main branch table.
  • Show commit autoclose status on the edit screen.
  • Add documentation about how to find these statuses and what they mean.
Test Plan
  • Read documentation.
  • Viewed branches and hovered over the various states.
  • Viewed commits in various states and checked the "Autoclose?" field.
  • Pushed some commits and saw autoclose activate.

Diff Detail

Repository
rP Phabricator
Branch
autoclose
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2344
Build 2348: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve documentation and tooling around autoclose.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 25 2014, 10:33 PM
epriestley updated this revision to Diff 24915.

Closed by commit rP53a678c56823 (authored by @epriestley).