Differential D10343

Provide some hints for Amazon RDS configuration
ClosedPublic
Actions

Authored by epriestley on Aug 25 2014, 2:27 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2605: Search on secure.phabricator.com doesn't find MySQL stopwords

Commits

Restricted Diffusion Commit
rP6dd82d86a2b7: Provide some hints for Amazon RDS configuration

Summary

Fixes T2605. Provide some instructions on configuring RDS properly. The "DB Parameter Group" thing in the web UI seems pretty easy to use, it's just not obvious that it's what you should be using.

Test Plan

Jiggled these warnings to trigger them, viewed the output, saw a table of values and a hint about RDS.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24900.Aug 25 2014, 2:27 PM

epriestley retitled this revision from to Provide some hints for Amazon RDS configuration.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2605: Search on secure.phabricator.com doesn't find MySQL stopwords.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 25 2014, 2:27 PM

Harbormaster completed remote builds in B2338: Diff 24900.Aug 25 2014, 2:28 PM

epriestley added inline comments.Aug 25 2014, 2:29 PM

src/applications/config/check/PhabricatorSetupCheckMySQL.php
145	I made this change because a user in IRC is reporting that their setting is set to 6, apparently (??). I figure users who legitimately want to have this at 6 can just ignore the warning. This seems unusual.

Nice, I love a good doc.

src/applications/config/check/PhabricatorSetupCheckMySQL.php
149–150	might as well use $min_len here instead of 4
src/docs/user/userguide/amazon_rds.diviner
10	support meaning our ability to help you? (or said differently, all features should work?)