Ref T4284. This fixes at least one problem which can cause the observed behavior.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL)
- Commits
- Restricted Diffusion Commit
rP241cfc2e8312: Don't leave temporary files around when trying to use credentials with…
- Before applying patch, used PHABRICATOR_CREDENTIAL=PHID-CDTL-... bin/ssh-connect + debugging prints to verify the keyfile was written and cleaned up normally.
- Destroyed the credental, verified the temporary file was not cleand up correctly.
- Applied patch, verified temporary file was not written and command exited with sensible error.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped