Paths

Table of Contentst

Differential D10328

Don't leave temporary files around when trying to use credentials with destroyed secrets
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 6:21 PM.

Tags

None

Referenced Files

	F14765764: D10328.id24863.diff
	Thu, Jan 23, 3:50 PM

	F14765763: D10328.id24859.diff
	Thu, Jan 23, 3:50 PM

	F14765761: D10328.id.diff
	Thu, Jan 23, 3:50 PM

	F14765760: D10328.diff
	Thu, Jan 23, 3:50 PM

	Unknown Object (File)
	Wed, Jan 22, 12:17 AM

	Unknown Object (File)
	Tue, Jan 21, 9:30 PM

	Unknown Object (File)
	Thu, Jan 16, 8:12 AM

	Unknown Object (File)
	Fri, Jan 3, 5:54 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL)

Commits

Restricted Diffusion Commit
rP241cfc2e8312: Don't leave temporary files around when trying to use credentials with…

Summary

Ref T4284. This fixes at least one problem which can cause the observed behavior.

Test Plan

Before applying patch, used PHABRICATOR_CREDENTIAL=PHID-CDTL-... bin/ssh-connect + debugging prints to verify the keyfile was written and cleaned up normally.
Destroyed the credental, verified the temporary file was not cleand up correctly.
Applied patch, verified temporary file was not written and command exited with sensible error.

Diff Detail

Repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 24859.Aug 21 2014, 6:21 PM

epriestley retitled this revision from to Don't leave temporary files around when trying to use credentials with destroyed secrets.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL).

Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 6:21 PM

Harbormaster completed remote builds in B2318: Diff 24859.Aug 21 2014, 6:22 PM

btrahan accepted this revision.Aug 21 2014, 6:24 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 21 2014, 6:24 PM

Closed by commit rP241cfc2e8312 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

passphrase/

keys/

PassphraseSSHKey.php

17 lines

Diff 24863

src/applications/passphrase/keys/PassphraseSSHKey.php

Loading...