Page MenuHomePhabricator
Differential D10328

Don't leave temporary files around when trying to use credentials with destroyed secrets
ClosedPublic
Actions

Authored by epriestley on Aug 21 2014, 6:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 9:20 PM
Unknown Object (File)
Thu, Jan 23, 8:30 PM
Unknown Object (File)
Thu, Jan 23, 6:55 PM
Unknown Object (File)
Thu, Jan 23, 3:50 PM
Unknown Object (File)
Thu, Jan 23, 3:50 PM
Unknown Object (File)
Thu, Jan 23, 3:50 PM
Unknown Object (File)
Thu, Jan 23, 3:50 PM
Unknown Object (File)
Wed, Jan 22, 12:17 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL)
Commits
Restricted Diffusion Commit
rP241cfc2e8312: Don't leave temporary files around when trying to use credentials with…
Summary

Ref T4284. This fixes at least one problem which can cause the observed behavior.

Test Plan
  • Before applying patch, used PHABRICATOR_CREDENTIAL=PHID-CDTL-... bin/ssh-connect + debugging prints to verify the keyfile was written and cleaned up normally.
  • Destroyed the credental, verified the temporary file was not cleand up correctly.
  • Applied patch, verified temporary file was not written and command exited with sensible error.

Diff Detail

Repository
rP Phabricator
Branch
fatalphrase
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2318
Build 2322: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24859.Aug 21 2014, 6:21 PM
epriestley retitled this revision from to Don't leave temporary files around when trying to use credentials with destroyed secrets.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T4284: Temporary files are not removed when PHP double-fatals (e.g., method call on NULL).
Herald added a subscriber: epriestley. · View Herald TranscriptAug 21 2014, 6:21 PM
Harbormaster completed remote builds in B2318: Diff 24859.Aug 21 2014, 6:22 PM
btrahan accepted this revision.Aug 21 2014, 6:24 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 21 2014, 6:24 PM
epriestley closed this revision.Aug 21 2014, 6:26 PM
epriestley updated this revision to Diff 24863.

Closed by commit rP241cfc2e8312 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
passphrase/
keys/
17 lines

Diff 24859

View Options

src/applications/passphrase/keys/PassphraseSSHKey.php

Loading...
Phabricator · Built by Phacility