Looks like I missed this when implementing custom actions and hence you can't currently use custom actions on the pre-commit adapters.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- Restricted Diffusion Commit
rP2fd395e859bb: Allow pre-commit adapter to use custom actions
Added a custom action to a pre-commit Herald rule.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- precommit-custom-action
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2298 Build 2302: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Oops. Looks like that just fixes the UI; it doesn't fix the actual triggering of the actions.
src/applications/diffusion/herald/HeraldPreCommitAdapter.php | ||
---|---|---|
127 | pht regression :o |
src/applications/diffusion/herald/HeraldPreCommitAdapter.php | ||
---|---|---|
127 | Ouch, these are missing pht in all the classes; I'll go fix the other adapters up as well. |