Page MenuHomePhabricator
Differential D10301

Cover redirects to files in more cases
ClosedPublic
Actions

Authored by epriestley on Aug 19 2014, 10:43 PM.
Tags
None
Referenced Files
F15506072: D10301.diff
Tue, Apr 15, 8:27 AM
F15504108: D10301.id24803.diff
Mon, Apr 14, 3:54 PM
F15502495: D10301.id24808.diff
Mon, Apr 14, 1:35 AM
F15487522: D10301.id24808.diff
Thu, Apr 10, 2:49 PM
F15487521: D10301.id24803.diff
Thu, Apr 10, 2:49 PM
F15418548: D10301.diff
Thu, Mar 20, 11:59 PM
F15414482: D10301.id24808.diff
Thu, Mar 20, 12:49 AM
F15386748: D10301.id24803.diff
Mar 15 2025, 1:14 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5894: Thumbnails of uploaded files broken when not logged in
Commits
Restricted Diffusion Commit
rP94cdddc211d1: Cover redirects to files in more cases
Summary

Ref T5894. We have a couple more similar cases. Make them all do a decision-based redirect for now.

Test Plan

Did "View Raw File" and such, and also made sure thumbnails still work.

Diff Detail

Repository
rP Phabricator
Branch
fdel2
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/files/storage/PhabricatorFile.php:973XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 2281
Build 2285: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24803.Aug 19 2014, 10:43 PM
epriestley retitled this revision from to Cover redirects to files in more cases.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad.
epriestley added a task: T5894: Thumbnails of uploaded files broken when not logged in.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 19 2014, 10:43 PM
Harbormaster completed remote builds in B2281: Diff 24803.Aug 19 2014, 10:45 PM
chad accepted this revision.Aug 19 2014, 10:47 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Aug 19 2014, 10:47 PM
epriestley closed this revision.Aug 19 2014, 10:53 PM
epriestley updated this revision to Diff 24808.

Closed by commit rP94cdddc211d1 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
controller/
3 lines
2 lines
diffusion/
controller/
2 lines
2 lines
files/
controller/
16 lines
storage/
19 lines

Diff 24803

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Loading...
View Options

src/applications/differential/controller/DifferentialRevisionViewController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionBrowseFileController.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...
View Options

src/applications/files/controller/PhabricatorFileTransformController.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
Phabricator · Built by Phacility