Differential D10295

Login to Comment - kill intermediary dialogue
ClosedPublic
Actions

Authored by btrahan on Aug 19 2014, 6:52 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T5906: "Login to Comment" should lead to login screen

Commits

Restricted Diffusion Commit
rP20d6c7a04879: Login to Comment - kill intermediary dialogue

Summary

its not necessary. Fixes T5906

Test Plan

clicked "Login to Comment" and went straight to the login form, sans intermediary dialogue

Diff Detail

Repository

rP Phabricator

Branch

T5906

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2272
Build 2276: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 24790.Aug 19 2014, 6:52 PM

btrahan added a task: T5906: "Login to Comment" should lead to login screen.

btrahan retitled this revision from to Login to Comment - kill intermediary dialogue.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 19 2014, 6:52 PM

Harbormaster completed remote builds in B2272: Diff 24790.Aug 19 2014, 6:53 PM

epriestley accepted this revision.Aug 19 2014, 8:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 19 2014, 8:59 PM

Closed by commit rP20d6c7a04879 (authored by @btrahan).

Revision Contents
Changeset List

Path

Size

src/

applications/

transactions/

view/

PhabricatorApplicationTransactionCommentView.php

1 line

Diff 24790

View Options

src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php

Login to Comment - kill intermediary dialogueClosedPublicActions