Differential D10290

Include all audit states in audit.query
ClosedPublic
Actions

Authored by cburroughs on Aug 18 2014, 7:36 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

Restricted Diffusion Commit
rPfd45f64e4782: Include all audit states in audit.query

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Additional audit states were made queryable for T5871.
Include them in Conduit's audit.query as well. In doing so corrects
references from "status-foo" to "audit-status-foo".

Depends on D10271

Test Plan

with an api, issues queries and got sensible results

Diff Detail

Repository

rP Phabricator

Branch

audit-conduit

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	src/applications/audit/conduit/AuditQueryConduitAPIMethod.php:26	TXT3	Line Too Long

Unit

No Test Coverage

Build Status

Buildable 2266
Build 2270: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

cburroughs updated this revision to Diff 24778.Aug 18 2014, 7:36 PM

cburroughs retitled this revision from to Include all audit states in audit.query.

cburroughs updated this object.

cburroughs edited the test plan for this revision. (Show Details)

cburroughs added a parent revision: D10271: Audit - allow queries for "partial" and "accepted" audits.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 18 2014, 7:36 PM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B2266: Diff 24778.Aug 18 2014, 7:37 PM

epriestley requested changes to this revision.Aug 21 2014, 12:31 PM

epriestley added a reviewer: epriestley.

epriestley added inline comments.

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php
26	Please fix this lint warning.

This revision now requires changes to proceed.Aug 21 2014, 12:31 PM

break long line

Herald added a subscriber: Korvin. · View Herald TranscriptAug 21 2014, 12:47 PM

Harbormaster completed remote builds in B2310: Diff 24848.Aug 21 2014, 12:48 PM

epriestley accepted this revision.Aug 21 2014, 12:50 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 21 2014, 12:50 PM

Closed by commit rPfd45f64e4782 (authored by @cburroughs, committed by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

audit/

conduit/

AuditQueryConduitAPIMethod.php

9 lines

Diff 24778

View Options

src/applications/audit/conduit/AuditQueryConduitAPIMethod.php

Include all audit states in audit.queryClosedPublicActions