Differential D10260

Surface a better warning when the LDAP extension is not installed
ClosedPublic
Actions

Authored by epriestley on Aug 13 2014, 9:07 PM.

Details

Reviewers

btrahan

Maniphest Tasks

Restricted Maniphest Task

Commits

Restricted Diffusion Commit
rPef0460c1ffee: Surface a better warning when the LDAP extension is not installed

Summary

Fixes T3347. We can't really do this one as a config thing since we don't know if the user wants to use LDAP.

Instead, just give them a better message than they otherwise get when they try to install/configure/use LDAP.

Test Plan

Faked it and got a reasonable message.

Diff Detail

Repository

rP Phabricator

Branch

ldapwarn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2216
Build 2220: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24696.Aug 13 2014, 9:07 PM

epriestley retitled this revision from to Surface a better warning when the LDAP extension is not installed.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: Restricted Maniphest Task.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 13 2014, 9:07 PM

Harbormaster completed remote builds in B2216: Diff 24696.Aug 13 2014, 9:08 PM

btrahan accepted this revision.Aug 13 2014, 9:57 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 13 2014, 9:57 PM

Closed by commit rPef0460c1ffee (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

management/

PhabricatorAuthManagementLDAPWorkflow.php

2 lines

provider/

PhabricatorLDAPAuthProvider.php

14 lines

Diff 24696

View Options

src/applications/auth/management/PhabricatorAuthManagementLDAPWorkflow.php