Page MenuHomePhabricator
Differential D10253

Add autocomplete=off to all non-login password forms
ClosedPublic
Actions

Authored by epriestley on Aug 13 2014, 2:41 PM.
Tags
None
Referenced Files
F14043876: D10253.id24684.diff
Tue, Nov 12, 1:40 PM
F14033065: D10253.diff
Sat, Nov 9, 4:34 PM
F14021529: D10253.diff
Wed, Nov 6, 9:48 AM
F14014798: D10253.diff
Sun, Nov 3, 8:39 AM
F14004203: D10253.id24684.diff
Sat, Oct 26, 5:04 PM
F14004202: D10253.id24687.diff
Sat, Oct 26, 5:04 PM
F14001303: D10253.diff
Fri, Oct 25, 6:14 AM
F14001297: D10253.id.diff
Fri, Oct 25, 6:10 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T5579: LDAP settings page allows autocomplete on the Anonymous Username/Password field in Chrome
Commits
Restricted Diffusion Commit
rPbcdadf5947b3: Add autocomplete=off to all non-login password forms
Summary

Fixes T5579. Modern browsers aggressively autofill credentials, but at least Firefox still behaves slightly better with this flag. Hopefully other browsers will follow suit.

Test Plan

Browsed various interfaces, verifying that login interfaces allow autocomplete while non-login interfaces do not.

Diff Detail

Repository
rP Phabricator
Branch
autocomplete
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 2207
Build 2211: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24684.Aug 13 2014, 2:41 PM
epriestley retitled this revision from to Add autocomplete=off to all non-login password forms.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5579: LDAP settings page allows autocomplete on the Anonymous Username/Password field in Chrome.
Herald added a subscriber: epriestley. · View Herald TranscriptAug 13 2014, 2:41 PM
Harbormaster completed remote builds in B2207: Diff 24684.Aug 13 2014, 2:42 PM
btrahan accepted this revision.Aug 13 2014, 4:23 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 13 2014, 4:23 PM
epriestley closed this revision.Aug 13 2014, 5:06 PM
epriestley updated this revision to Diff 24687.

Closed by commit rPbcdadf5947b3 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
auth/
provider/
1 line
5 lines
diffusion/
panel/
3 lines
passphrase/
controller/
1 line
credentialtype/
3 lines
people/
controller/
17 lines
settings/
panel/
2 lines
view/
form/
control/
8 lines

Diff 24684

View Options

src/applications/auth/provider/PhabricatorLDAPAuthProvider.php

Loading...
View Options

src/applications/auth/provider/PhabricatorOAuthAuthProvider.php

Loading...
View Options

src/applications/diffusion/panel/DiffusionSetPasswordPanel.php

Loading...
View Options

src/applications/passphrase/controller/PassphraseCredentialEditController.php

Loading...
View Options

src/applications/passphrase/credentialtype/PassphraseCredentialTypePassword.php

Loading...
View Options

src/applications/people/controller/PhabricatorPeopleLdapController.php

Loading...
View Options

src/applications/settings/panel/PhabricatorSettingsPanelPassword.php

Loading...
View Options

src/view/form/control/AphrontFormPasswordControl.php

Loading...
Phabricator · Built by Phacility