Details

src/xsprintf/csprintf.php
66	Putting: if ($is_powershell) { throw new Exception('blah'); } does get hit and causes `__toString() can not throw exception` in the daemon log.
164	But the command that's run is never this, and always appears to use UNIX escaping.

Now working

epriestley requested changes to this revision.Aug 13 2014, 2:07 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/xsprintf/PhutilCommandString.php
33–36	Let's make this setEscapingMode(PhutilCommandString::MODE_POWERSHELL) or similar.
43	...then pass 'mode'
src/xsprintf/__tests__/PhutilCsprintfTestCase.php
27	Then eventually this test would become setEscapingMode(PhutilCommandString::MODE_LINUX) and the test would work under windows, in a future far away.
src/xsprintf/csprintf.php
111–112	Let's move this to PhutilCommandString::escapeArgument($argument, $mode = PhutilCommandString::MODE_DEFAULT) instead of defining a new `escapepowershell`. That should reduce code duplication too, and make real modal operation easy to implement later.
149	In single quotes, I think this means literally "backslash a".
150	Same issue here, this is "backslash b"

This revision now requires changes to proceed.Aug 13 2014, 2:07 AM

Changes based on feedback

Change \a and \b to use chr()

epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 13 2014, 2:34 AM

Closed by commit rPHU49f08a756a54 (authored by @hach-que).

Allow PhutilCommandString to escape as Powershell
ClosedPublic
Actions