Page MenuHomePhabricator

Convert `pushlog` and `refcursor` to BLOB storage
ClosedPublic

Authored by epriestley on Aug 11 2014, 3:51 PM.
Tags
None
Referenced Files
F14023946: D10217.diff
Thu, Nov 7, 4:22 AM
F13988008: D10217.id24580.diff
Mon, Oct 21, 12:35 PM
F13964967: D10217.id24598.diff
Tue, Oct 15, 10:59 PM
Unknown Object (File)
Sat, Oct 12, 5:50 PM
Unknown Object (File)
Oct 1 2024, 2:20 PM
Unknown Object (File)
Sep 27 2024, 10:43 AM
Unknown Object (File)
Sep 18 2024, 11:29 PM
Unknown Object (File)
Sep 18 2024, 11:06 PM
Subscribers

Details

Summary

Fixes T5840. Some time ago I incorrectly believed that latin1_bin collation was synonymous with "binary". It is not, and does not permit UTF8 characters outside of BMP, among other sequences.

These two tables currently have LONGTEXT columns which should be LONGBLOB. The table design is explicilty intended to accommodate invalid/unreasonably long ref names, but the collation prevents this from working properly.

After T1191, we'll have a general system for resolving this, but a user hit an issue yesterday (T5840) with a brnach name containing Chinese characters.

Test Plan
  • Tried emoji inserts into both tables, was rebuffed.
  • Ran migration.
  • Performed emoji inserts into both tables.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Convert `pushlog` and `refcursor` to BLOB storage.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.

I just can't believe you didn't test emoji branch names at the beginning. :P

This revision is now accepted and ready to land.Aug 11 2014, 6:34 PM
epriestley updated this revision to Diff 24598.

Closed by commit rP31e1653a4e45 (authored by @epriestley).