- Fixes T5851. Currently, if a commit has Fixes T123, we generate an email with just that before generating the commit email. Don't send/publish transactions about a commit before it imports (this is a tiny bit hacky, but well-contained and I don't think it causes any problems).
- Fixes T4864. Currently, we try to parse Differential information even if Differential is not installed. Instead, do this only if Differential is installed.
- Fixes T5771. Currently, if we can't figure out who the committer/author of a commit is, we don't publish a Fixes T123 transaction. Instead, fall back to acting as "Diffusion" if we can't find a better actor. Most of this diff expands the role of application actors. The existing application actors (Herald and Harbormaster) seem to be working well.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T5771: Use application actors when no commit author is available
T4864: When Differential is uninstalled, commit message parser still attempts to run application integrations
T5851: "Fixes XXX" in commits is generating a separate transaction email - Commits
- Restricted Diffusion Commit
rPd38e89ef6ba5: Fix several issues with application interactions while importing commits
- Pushed a commit with Fixes T123 and verified it did not generate email directly. (The task half of the transaction still does, correctly.)
- Uninstalled Differential and pushed a commit, got a clean import instead of an exception.
- Commented out author/committer PHIDs and pushed stuff, saw a "Diffusion" actor.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- comactor
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 2153 Build 2157: [Placeholder Plan] Wait for 30 Seconds