Page MenuHomePhabricator
Differential D10185

T5409, allow bin/remove to permanently destroy credential and everything associated with it
ClosedPublic
Actions

Authored by lpriestley on Aug 7 2014, 11:09 PM.
Tags
None
Referenced Files
F14863231: D10185.id24502.diff
Fri, Feb 7, 10:19 PM
F14863230: D10185.id24501.diff
Fri, Feb 7, 10:19 PM
F14863229: D10185.id24500.diff
Fri, Feb 7, 10:19 PM
F14863228: D10185.id.diff
Fri, Feb 7, 10:19 PM
F14863226: D10185.diff
Fri, Feb 7, 10:19 PM
Unknown Object (File)
Fri, Feb 7, 9:20 AM
Unknown Object (File)
Fri, Jan 31, 6:43 PM
Unknown Object (File)
Thu, Jan 23, 3:09 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T5409: Allow /bin/remove to destroy permanently a passphrase record
Commits
Restricted Diffusion Commit
rPc6998207ab00: T5409, allow bin/remove to permanently destroy credential and everything…
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

Fixes T5409, bin/remove permanently destroys credential

Test Plan

Add a passphrase, run bin/remove destroy K123 --trace, verify credential no longer exists

Diff Detail

Repository
rP Phabricator
Branch
destroycredential
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2097
Build 2101: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 24500.Aug 7 2014, 11:09 PM
lpriestley retitled this revision from to T5409, allow bin/remove to permanently destroy credential and everything associated with it.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T5409: Allow /bin/remove to destroy permanently a passphrase record.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptAug 7 2014, 11:09 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: Korvin, epriestley. · View Herald Transcript
Harbormaster completed remote builds in B2096: Diff 24500.Aug 7 2014, 11:10 PM
epriestley requested changes to this revision.Aug 7 2014, 11:14 PM
epriestley edited edge metadata.
  • One minor issue inline.
  • you betta sign that CLA
src/applications/passphrase/storage/PassphraseCredential.php
95

This isn't quiet correct -- it should be $this->secretID(). Currently this is destroying the Secret that happens to have the same ID as the Credential, but they aren't guaranteed to be related.

This revision now requires changes to proceed.Aug 7 2014, 11:14 PM
lpriestley updated this revision to Diff 24501.Aug 7 2014, 11:20 PM
lpriestley edited edge metadata.

Adding requested changes

Harbormaster completed remote builds in B2097: Diff 24501.Aug 7 2014, 11:21 PM
epriestley accepted this revision.Aug 7 2014, 11:33 PM
epriestley edited edge metadata.

This revision is now accepted and ready to land.Aug 7 2014, 11:33 PM
epriestley closed this revision.Aug 7 2014, 11:34 PM
epriestley updated this revision to Diff 24502.

Closed by commit rPc6998207ab00 (authored by @lpriestley, committed by @epriestley).

Revision Contents
Changeset List

PathSize
src/
applications/
passphrase/
storage/
18 lines
system/
interface/
2 lines

Diff 24501

View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/system/interface/PhabricatorDestructibleInterface.php

Loading...
Phabricator · Built by Phacility