Paths

Table of Contentst

Differential D10151

Make `#` header detection more strict
ClosedPublic
Actions

Authored by epriestley on Aug 5 2014, 4:01 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T5102: Markdown syntax of README.md file present in a repository is not well rendered

Commits

rPHU25c1599e34e0: Make `#` header detection more strict

Summary

Ref T5102. Require a space after a single # at the beginning of a line to possibly trigger header behavior.

This prevents conflicts with #projects and some normal text beginning with #.

Test Plan

Added unit test.

Diff Detail

Repository

rPHU libphutil

Branch

headercons

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2046
Build 2047: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 24418.Aug 5 2014, 4:01 PM

epriestley retitled this revision from to Make `#` header detection more strict.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T5102: Markdown syntax of README.md file present in a repository is not well rendered.

Herald added a subscriber: epriestley. · View Herald TranscriptAug 5 2014, 4:01 PM

Harbormaster completed remote builds in B2046: Diff 24418.Aug 5 2014, 4:02 PM

spacecat

btrahan accepted this revision.Aug 5 2014, 4:18 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Aug 5 2014, 4:18 PM

Closed by commit rPHU25c1599e34e0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

markup/

engine/

__tests__/

remarkup/

header-skip.txt

11 lines

remarkup/

blockrule/

PhutilRemarkupHeaderBlockRule.php

2 lines

Diff 24418

View Options

src/markup/engine/tests/remarkup/header-skip.txt

View Options

src/markup/engine/remarkup/blockrule/PhutilRemarkupHeaderBlockRule.php

Make `#` header detection more strictClosedPublicActions