Page MenuHomePhabricator

Terminate other sessions on credential changes
ClosedPublic

Authored by epriestley on Aug 3 2014, 6:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 7:16 AM
Unknown Object (File)
Wed, Sep 25, 6:17 AM
Unknown Object (File)
Wed, Sep 25, 6:14 AM
Unknown Object (File)
Wed, Sep 25, 6:13 AM
Unknown Object (File)
Wed, Sep 25, 6:11 AM
Unknown Object (File)
Thu, Sep 5, 9:21 AM
Unknown Object (File)
Thu, Sep 5, 9:20 AM
Unknown Object (File)
Thu, Sep 5, 9:20 AM
Subscribers

Details

Summary

Fixes T5509. Currently, existing sessions live on even if you change your password.

Over the course of the program, we've recieved a lot of HackerOne reports that sessions do not terminate when users change their passwords. I hold that this isn't a security vulnerability: users can explicitly manage sessions, and this is more general and more powerful than tying session termination to password resets. In particular, many installs do not use a password provider at all (and no researcher has reported this in a general, application-aware way that discusses multiple authentication providers).

That said, dealing with these false positives is vaguely time consuming, and the "expected" behavior isn't bad for users, so just align behavior with researcher expectations: when passwords are changed, providers are removed, or multi-factor authentication is added to an account, terminate all other active login sessions.

Test Plan
  • Using two browsers, established multiple login sessions.
  • In one browser, changed account password. Saw session terminate and logout in the second browser.
  • In one browser, removed an authentication provider. Saw session terminate and logout in the second browser.
  • In one browser, added MFA. Saw session terminate and logout in the second browser.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Terminate other sessions on credential changes.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2014, 6:53 PM
epriestley updated this revision to Diff 24404.

Closed by commit rP95eeffff7e5d (authored by @epriestley).